Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGNITE-15922 Implement NUMA-aware allocator #9569

Closed
wants to merge 8 commits into from
Closed

IGNITE-15922 Implement NUMA-aware allocator #9569

wants to merge 8 commits into from

Conversation

ivandasch
Copy link
Contributor

@ivandasch ivandasch commented Nov 17, 2021 •
edited
Loading

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

timoninmaxim
timoninmaxim reviewed Nov 22, 2021
View reviewed changes
modules/core/src/main/java/org/apache/ignite/mem/MemoryAllocator.java Outdated Show resolved Hide resolved
modules/core/src/main/java/org/apache/ignite/configuration/DataRegionConfiguration.java Show resolved Hide resolved
modules/core/src/main/java/org/apache/ignite/internal/mem/unsafe/UnsafeMemoryProvider.java Outdated Show resolved Hide resolved
modules/numa-allocator/src/test/java/org/apache/ignite/internal/mem/NumaAllocatorUnitTest.java Show resolved Hide resolved
modules/numa-allocator/src/test/java/org/apache/ignite/internal/mem/NumaAllocatorBasicTest.java Outdated Show resolved Hide resolved
modules/numa-allocator/src/main/java/org/apache/ignite/mem/LocalNumaAllocationStrategy.java Show resolved Hide resolved
modules/numa-allocator/src/main/java/org/apache/ignite/internal/mem/NumaAllocUtil.java Show resolved Hide resolved
modules/numa-allocator/src/main/cpp/CMakeLists.txt Outdated Show resolved Hide resolved
modules/numa-allocator/src/main/cpp/src/numa/numa_alloc.cpp Outdated Show resolved Hide resolved
modules/core/src/main/java/org/apache/ignite/mem/MemoryAllocator.java Outdated Show resolved Hide resolved
@ivandasch ivandasch force-pushed the ignite-15922 branch 4 times, most recently from 85938f5 to cdbb118 Compare November 23, 2021 10:06
SammyVimes
SammyVimes requested changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@SammyVimes SammyVimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But I think some parts should be a little bit more documented

modules/numa-allocator/pom.xml Outdated Show resolved Hide resolved
modules/numa-allocator/src/main/cpp/src/numa/numa_alloc.cpp Outdated Show resolved Hide resolved
modules/numa-allocator/src/main/cpp/src/numa/numa_alloc.cpp Show resolved Hide resolved
modules/numa-allocator/src/main/java/org/apache/ignite/internal/mem/NumaAllocUtil.java Show resolved Hide resolved
modules/numa-allocator/src/main/cpp/include/numa/numa_alloc.h

~BitSet();

class Reference {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get where this class is used. I see that it captures the position in a bitset and an object of the Reference is returned by the [] op. Is it used in the internals of the libnuma?

Copy link
Contributor Author

@ivandasch ivandasch Nov 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is not used. This is quite common technique (see i.e. bitset implementation in libstdc++) to implement non-const operator[]. With it you can do somethin like this

BitSet a, b;
a[0] = true;
for (size_t i = 0; i < a.Size() && i < b.Size(); ++i) {
     a[i] = !b[i];
}

But this functionality is not used so far, it is for probably future uses

@ivandasch ivandasch force-pushed the ignite-15922 branch 2 times, most recently from 7120fb7 to 39f9d46 Compare November 29, 2021 11:56
rpuch
rpuch reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@rpuch rpuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! Just a couple of comments from my side (not mandatory, obviously).

modules/numa-allocator/src/main/java/org/apache/ignite/mem/NumaAllocator.java Outdated Show resolved Hide resolved
modules/numa-allocator/src/main/java/org/apache/ignite/mem/SimpleNumaAllocationStrategy.java Outdated Show resolved Hide resolved
@ivandasch ivandasch closed this in 3c27c15 Dec 13, 2021
ivandasch added a commit to ivandasch/ignite that referenced this pull request Dec 13, 2021
@ivandasch
IGNITE-15922 Implement NUMA-aware allocator - Fixes apache#9569.
f799a30 
Signed-off-by: Ivan Daschinsky <ivandasch@apache.org>
(cherry picked from commit 3c27c15)
Sega76 pushed a commit to Sega76/ignite that referenced this pull request Dec 13, 2021
@ivandasch @Sega76
IGNITE-15922 Implement NUMA-aware allocator - Fixes apache#9569.
5db9a83 
Signed-off-by: Ivan Daschinsky <ivandasch@apache.org>
(cherry picked from commit 3c27c15)
ivandasch added a commit to ivandasch/ignite that referenced this pull request Dec 14, 2021
@ivandasch
IGNITE-15922 Implement NUMA-aware allocator - Fixes apache#9569.
0d517b9 
Signed-off-by: Ivan Daschinsky <ivandasch@apache.org>
(cherry picked from commit 3c27c15)
Sega76 pushed a commit to Sega76/ignite that referenced this pull request Dec 15, 2021
IGN-4419 Backport of: IGNITE-15922 Implement NUMA-aware allocator
ce35c1e 
Squashed commit of the following:

commit 0d517b9
Author: Ivan Daschinsky <ivandasch@apache.org>
Date:   Mon Dec 13 16:09:50 2021 +0300

    IGNITE-15922 Implement NUMA-aware allocator - Fixes apache#9569.

    Signed-off-by: Ivan Daschinsky <ivandasch@apache.org>
    (cherry picked from commit 3c27c15)
Sega76 pushed a commit to Sega76/ignite that referenced this pull request Jan 11, 2022
@Sega76
IGN-4419 Backport of: IGNITE-15922 Implement NUMA-aware allocator
67e8eab 
Squashed commit of the following:

commit 0d517b9
Author: Ivan Daschinsky <ivandasch@apache.org>
Date:   Mon Dec 13 16:09:50 2021 +0300

    IGNITE-15922 Implement NUMA-aware allocator - Fixes apache#9569.

    Signed-off-by: Ivan Daschinsky <ivandasch@apache.org>
    (cherry picked from commit 3c27c15)
Sega76 pushed a commit to Sega76/ignite that referenced this pull request Jan 12, 2022
@Sega76
IGN-4419 Backport of: IGNITE-15922 Implement NUMA-aware allocator
15cda69 
Squashed commit of the following:

commit 0d517b9
Author: Ivan Daschinsky <ivandasch@apache.org>
Date:   Mon Dec 13 16:09:50 2021 +0300

    IGNITE-15922 Implement NUMA-aware allocator - Fixes apache#9569.

    Signed-off-by: Ivan Daschinsky <ivandasch@apache.org>
    (cherry picked from commit 3c27c15)
xintrian pushed a commit to xintrian/ignite that referenced this pull request May 27, 2022
@ivandasch
IGNITE-15922 Implement NUMA-aware allocator - Fixes apache#9569.
2810c51 
Signed-off-by: Ivan Daschinsky <ivandasch@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zstan zstan zstan approved these changes

@rpuch rpuch rpuch approved these changes

@AMashenkov AMashenkov AMashenkov approved these changes

@SammyVimes SammyVimes SammyVimes approved these changes

@timoninmaxim timoninmaxim timoninmaxim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ivandasch @zstan @rpuch @AMashenkov @SammyVimes @timoninmaxim