Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(healthcheck): the checker name is wrong if APISIX works under multiple processes. #568

Closed
membphis opened this issue Sep 23, 2019 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@membphis
Copy link
Member

For a specified upstream, the same name should be used to ensure that the checker objects created between different workers can share the same health check result.

https://github.com/iresty/apisix/blob/master/lua/apisix/balancer.lua#L76

For example, if we got the upstream from a Route, then the name should be /routes/{id}; if we got the upstream from a Service, then the name should be /service/{id}.

@membphis membphis added the bug Something isn't working label Sep 23, 2019
@membphis membphis added this to the ver 0.8 milestone Sep 23, 2019
@membphis
Copy link
Member Author

fixed: #586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant