Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency to proj4j-epsg #840

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Remove the dependency to proj4j-epsg #840

merged 1 commit into from
Mar 2, 2024

Conversation

bchapuis
Copy link
Member

@bchapuis bchapuis commented Mar 1, 2024

This removal aims at making the future releases of Baremaps compliant with Apache guidelines.

The Apache SIS documentation contains a good documentation on how to deal with EPSG. Baremaps now includes two CRS definitions in the source code (WGS 84 and WGS 84 / Pseudo-Mercator), so the EPSG database is not necessary anymore. One can still decide to add the EPSG database in the classpath afterward if needed.

https://sis.apache.org/epsg.html

Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@desruisseaux desruisseaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me.

@bchapuis
Copy link
Member Author

bchapuis commented Mar 2, 2024

Thanks a lot for taking the time to check this PR. I think this was the last non compliant dependency (what remains is a few datasets in the test directory).

@bchapuis bchapuis merged commit bde4e81 into main Mar 2, 2024
9 checks passed
@bchapuis bchapuis deleted the remove-proj4-epsg branch March 2, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants