Replace licensed datasets by sample datasets #841
Conversation
bchapuis
force-pushed
the
remove-test-data
branch
from
bf518e8
to
f5566cd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| double lon = Double.parseDouble(reader.getAttributeValue(null, ATTRIBUTE_NAME_LONGITUDE)); | ||
| var latAttribute = reader.getAttributeValue(null, ATTRIBUTE_NAME_LATITUDE); | ||
| var lonAttribute = reader.getAttributeValue(null, ATTRIBUTE_NAME_LONGITUDE); | ||
| var latValue = latAttribute != null ? Double.parseDouble(latAttribute) : Double.NaN; |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| var latAttribute = reader.getAttributeValue(null, ATTRIBUTE_NAME_LATITUDE); | ||
| var lonAttribute = reader.getAttributeValue(null, ATTRIBUTE_NAME_LONGITUDE); | ||
| var latValue = latAttribute != null ? Double.parseDouble(latAttribute) : Double.NaN; | ||
| var lonValue = lonAttribute != null ? Double.parseDouble(lonAttribute) : Double.NaN; |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException Note
| /** {@inheritDoc} */ | ||
| @Override | ||
| public void accept(Change change) { | ||
| switch (change.getType()) { |
Check warning
Code scanning / CodeQL
Missing enum case in switch Warning
| .build(); | ||
| var topDocs = searcher.search(geonamesQuery, 2); | ||
| assertEquals(2, topDocs.totalHits.value); | ||
| var doc0 = searcher.doc(topDocs.scoreDocs[0].doc); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
| assertEquals(2, topDocs.totalHits.value); | ||
| var doc0 = searcher.doc(topDocs.scoreDocs[0].doc); | ||
| assertEquals("Yverdon-les-bains", doc0.getField("name").stringValue()); | ||
| var doc1 = searcher.doc(topDocs.scoreDocs[1].doc); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
bchapuis
force-pushed
the
remove-test-data
branch
from
5e90157
to
e67478c
Compare
bchapuis
force-pushed
the
remove-test-data
branch
from
ea91829
to
55fb1cb
Compare
bchapuis
force-pushed
the
remove-test-data
branch
from
55fb1cb
to
42b5c80
Compare
|
| https://github.com/protomaps/PMTiles | ||
| The copied files are located in: | ||
| - baremaps-core/src/test/resources/pmtiles/ | ||
|
|
||
| This product includes code derived from pyosmium. | ||
| BSD 2-Clause "Simplified" License. | ||
| Please visit the following URL for the full text of the pyosmium license: | ||
| https://github.com/osmcode/pyosmium/blob/master/LICENSE.TXT | ||
| The derived files are: | ||
| - baremaps-core/src/main/java/org/apache/baremaps/openstreetmap/state/StateReader.java |
There was a problem hiding this comment.
In general, we need to preserve the Pyosmium license header. If we modify it, we can also add the Apache license header.
Here is a good example. https://issues.apache.org/jira/browse/LEGAL-626
There was a problem hiding this comment.
Thank you for the example. Yes, we can add the BSD license in the header. Pyosmium does not include a license headers in the python files, hence my original choice of referencing the license in the NOTICE file and in the javadoc.
| Apache License 2.0. | ||
| Please visit the following URL for the full text of the Planetiler license: | ||
| https://github.com/onthegomap/planetiler/blob/main/LICENSE |
There was a problem hiding this comment.
If a dependency uses the Apache License 2.0 (AL2) and includes a NOTICE file, we need to add the corresponding NOTICE file here.
https://github.com/onthegomap/planetiler/blob/main/NOTICE
There was a problem hiding this comment.
It depends on the specific license terms, but so far it seems that only the AL2 requires this.
There was a problem hiding this comment.
Notice that we don't include planetiler which has GPL dependencies, we only integrated a data structure. Therefore, I'm tempted to say that we don't need to include the content of their NOTICE file.
|
I can make some changes later and create a PR. We can discuss it on the new PR, which might be clearer. |
|
Overall, it shouldn't take too long to get from DISCLAIMER-WIP to DISCLAIMER. Thank you:) |
|
Thanks a lot, continuing the discussion in a new PR is a good idea. |
No description provided.