Skip to content

Commit

Permalink
fix(migration): fix unexpected defer unlock (#7634) (#7635)
Browse files Browse the repository at this point in the history
Co-authored-by: Lynwee <linwei.hou@merico.dev>
  • Loading branch information
github-actions[bot] and d4x1 authored Jun 19, 2024
1 parent 1250648 commit 637eab0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion backend/server/services/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,12 @@ var statusLock sync.Mutex
// This might be called concurrently across multiple API requests
func ExecuteMigration() errors.Error {
statusLock.Lock()
defer statusLock.Unlock()
if serviceStatus == SERVICE_STATUS_MIGRATING {
statusLock.Unlock()
return errors.BadInput.New("already migrating")
}
if serviceStatus == SERVICE_STATUS_READY {
statusLock.Unlock()
return nil
}
serviceStatus = SERVICE_STATUS_MIGRATING
Expand All @@ -147,6 +148,7 @@ func ExecuteMigration() errors.Error {
pipelineServiceInit()
statusLock.Lock()
serviceStatus = SERVICE_STATUS_READY
statusLock.Unlock()
return nil
}

Expand Down

0 comments on commit 637eab0

Please sign in to comment.