fix: start date of sprint is empty (#8222)

[Bug][Jira] start_date Field Empty in sprint Table After Upgrading DevLake from 0.21 to 1.0 with Jira Plugin #8221
apache · Nov 26, 2024 · ab05664 · ab05664
1 parent 1dfb12d
commit ab05664
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/backend/plugins/jira/e2e/sprint_test.go b/backend/plugins/jira/e2e/sprint_test.go
@@ -44,6 +44,7 @@ func TestSprintDataFlow(t *testing.T) {
 	// verify sprint extraction
 	dataflowTester.FlushTabler(&models.JiraSprint{})
 	dataflowTester.FlushTabler(&models.JiraBoardSprint{})
+	dataflowTester.FlushTabler(&models.JiraServerInfo{})
 	dataflowTester.Subtask(tasks.ExtractSprintsMeta, taskData)
 	dataflowTester.VerifyTable(
 		models.JiraSprint{},

diff --git a/backend/plugins/jira/tasks/apiv2models/sprint.go b/backend/plugins/jira/tasks/apiv2models/sprint.go
@@ -37,22 +37,17 @@ type Sprint struct {
 
 func (s Sprint) ToToolLayer(connectionId uint64, isServer bool) *models.JiraSprint {
 	sprint := &models.JiraSprint{
-		ConnectionId: connectionId,
-		SprintId:     s.ID,
-		Self:         s.Self,
-		State:        s.State,
-		Name:         s.Name,
-		// StartDate:     s.StartDate,
+		ConnectionId:  connectionId,
+		SprintId:      s.ID,
+		Self:          s.Self,
+		State:         s.State,
+		Name:          s.Name,
+		StartDate:     s.StartDate,
 		EndDate:       s.EndDate,
 		CompleteDate:  s.CompleteDate,
 		OriginBoardID: s.OriginBoardID,
 	}
-	// jira cloud
-	if !isServer {
-		sprint.StartDate = s.StartDate
-	}
-	// jira server
-	if isServer && s.ActivatedDate != nil {
+	if s.ActivatedDate != nil {
 		sprint.StartDate = s.ActivatedDate
 	}
 	return sprint