Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 6892 - avoid adding clause when table not present #6943

Merged
merged 4 commits into from
Jul 26, 2024
Merged

fix 6892 - avoid adding clause when table not present #6943

merged 4 commits into from
Jul 26, 2024

Conversation

Marco-De-Stefani
Copy link
Contributor

@Marco-De-Stefani Marco-De-Stefani commented Feb 8, 2024 •
edited
Loading

Summary

Fixing #6892
by removing the clause if the table does not exists

Does this close any open issues?

Closes #6892

@Marco-De-Stefani Marco-De-Stefani mentioned this pull request Feb 8, 2024
Closed
3 tasks
@d4x1
Copy link
Contributor

d4x1 commented Feb 9, 2024

LGTM.

klesh
klesh previously requested changes Apr 9, 2024
View reviewed changes
backend/plugins/gitlab/tasks/trigger_job_collector.go Outdated Show resolved Hide resolved
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 25, 2024
d4x1
d4x1 previously approved these changes Jul 25, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 25, 2024
@d4x1 d4x1 dismissed klesh’s stale review July 25, 2024 16:44

Problem solved.

@d4x1 d4x1 merged commit 2bf7f73 into apache:main Jul 26, 2024
9 of 10 checks passed
@meeroslaph
Copy link

Is this fix going to be included into any release?

@d4x1 d4x1 mentioned this pull request Aug 9, 2024
Merged
@d4x1
Copy link
Contributor

d4x1 commented Aug 9, 2024

@meeroslaph It's included in https://github.com/apache/incubator-devlake/releases/tag/v1.0.1-beta6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4x1 d4x1 d4x1 approved these changes

@klesh klesh klesh left review comments

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][GitLab] raw table is missing when collecting api trigger jobs
4 participants
@Marco-De-Stefani @d4x1 @meeroslaph @klesh