feat: resume pipelines on restart #7229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klesh
force-pushed
the
kw-resume-pipeline-after-restart
branch
from
c99bb36 to
e0490d1
Compare
klesh
force-pushed
the
kw-resume-pipeline-after-restart
branch
from
e0490d1 to
f162af8
Compare
abeizn
approved these changes
Apr 1, 2024
abeizn
pushed a commit
that referenced
this pull request
Apr 1, 2024
* feat: resume pipelines on restart * feat: gitextractor clone phase must be executed on resume * fix: subtasks always get skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use cases:
devlakecontainer gets restarted accidentallyWhy: currently, all running pipelines would be marked as FAILED on restart and all progress would be dropped, one would have to rerun all of them which is quite costly.
What: this PR would resume the running pipelines on the Subtask level.
How: resuming pipeline on subtask level could pick up most of the work which could reduce the cost drastically
Todo:
gitextractorrequires the repo to be cloned into the local storage for data collection, unfortunately, the repo would be gone after the container restarted, either we cache it by using a volume or we have to optimize the clone speed for the whole thing to make sense.Screenshots
Pipeline is running
Pipeline resumed successfully after restarted
