Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactoring to use simple ApiCollector #7609

Merged
merged 2 commits into from
Jun 17, 2024
Merged

refactor: refactoring to use simple ApiCollector #7609

merged 2 commits into from
Jun 17, 2024

Conversation

sstojak1
Copy link
Contributor

@sstojak1 sstojak1 commented Jun 11, 2024 •
edited
Loading

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
PR collector is now using the simple ApiCollector.

Does this close any open issues?

Closes 7457

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.
You can test this by creating a new Devlake Project that will scrape data from Bitbucket Server.
What you should notice is that there won't be duplicate date in _raw_bitbucket_server_api_pull_requests table and that extractApiPullRequests won't slow down.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/refactor This PR refactors existing features labels Jun 11, 2024
klesh
klesh approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 14, 2024
@sstojak1 sstojak1 changed the title refactoring to use simple ApiCollector rafactor: refactoring to use simple ApiCollector Jun 14, 2024
@sstojak1 sstojak1 changed the title rafactor: refactoring to use simple ApiCollector refactor: refactoring to use simple ApiCollector Jun 14, 2024
@sstojak1
Copy link
Contributor Author

@klesh branch synced with master. It's ready to be merged

@d4x1 d4x1 merged commit 208fa7f into apache:main Jun 17, 2024
9 of 10 checks passed
@sstojak1 sstojak1 deleted the feat-speed-up-pr-collector-extractor branch June 17, 2024 07:16
klesh pushed a commit that referenced this pull request Jul 16, 2024
@sstojak1 @klesh
refactoring to use simple ApiCollector (#7609)
8fe757e 
Co-authored-by: Josip Stojak <Josip.Stojak@infobip.com>
abeizn pushed a commit that referenced this pull request Jul 16, 2024
@klesh @sstojak1
refactoring to use simple ApiCollector (#7609) (#7743)
52433a8 
Co-authored-by: sstojak1 <18380216+sstojak1@users.noreply.github.com>
Co-authored-by: Josip Stojak <Josip.Stojak@infobip.com>
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klesh klesh klesh approved these changes

Assignees
No one assigned
Labels
component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer pr-type/refactor This PR refactors existing features size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor][Bitbucket_Server] Speed up PR collector/extractor
3 participants
@sstojak1 @klesh @d4x1