Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logs and update the steps when initing app #7662

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Add more logs and update the steps when initing app #7662

merged 2 commits into from
Jun 25, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Jun 25, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. Add some logs
  2. update the steps when initing backend

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.
image

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 25, 2024
@d4x1 d4x1 changed the title Dev0625 1 Add more logs and update the steps when initing app Jun 25, 2024
@d4x1 d4x1 self-assigned this Jun 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2024
@d4x1 d4x1 merged commit b355752 into main Jun 25, 2024
13 checks passed
@d4x1 d4x1 deleted the dev0625-1 branch June 25, 2024 08:46
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
* refactor(framework): add some logs and dispart `Init` from `CreateAndRunApiServer`

* refactor(framework): update initial steps
Copy link
Contributor

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Jun 25, 2024
d4x1 added a commit that referenced this pull request Jun 25, 2024
* refactor(framework): add some logs and dispart `Init` from `CreateAndRunApiServer`

* refactor(framework): update initial steps

Co-authored-by: Lynwee <linwei.hou@merico.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot/auto-cherry-pick-completed auto cherry pick completed lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants