Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: engineering overview dashboard #7717

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

Startrekzky
Copy link
Contributor

@Startrekzky Startrekzky commented Jul 11, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

  1. fix the default value of this filter. It should be an empty string
    image
    image

  2. fix the date range error.

    • previous: the time range is between STR_TO_DATE('$month','%Y-%m-%d') and STR_TO_DATE('$month','%Y-%m-%d') + INTERVAL 1 MONTH - INTERVAL 1 DAY;
    • while the right version should be between STR_TO_DATE('$month','%Y-%m-%d') and STR_TO_DATE('$month','%Y-%m-%d') + INTERVAL 1 MONTH;
  3. Honor the selected month filter in the two charts to make them consistent with the rest of charts
    image
    image

  4. Dynamically change the panel title based on the selected month
    image

  5. Add the mean value to the legend of all time-series panel
    image

  6. optimize SQLs of other panels

Screenshots

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. component/ext This issue or PR relates to external components, such as Grafana pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident labels Jul 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 11, 2024
@abeizn abeizn merged commit 87ca3d0 into apache:main Jul 11, 2024
8 checks passed
Startrekzky added a commit to merico-dev/lake that referenced this pull request Jul 11, 2024
* fix: engineering overview dashboard

* fix: dynamically change the panel title value

* fix: the time range filter of critical defects

---------

Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
Startrekzky added a commit that referenced this pull request Jul 11, 2024
* fix: engineering overview dashboard

* fix: dynamically change the panel title value

* fix: the time range filter of critical defects

---------

Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
@Startrekzky Startrekzky deleted the dashboard-louis branch August 16, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ext This issue or PR relates to external components, such as Grafana lgtm This PR has been approved by a maintainer pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants