Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: circleci date fields are inconsistent #7757

Merged
merged 3 commits into from
Jul 17, 2024
Merged

fix: circleci date fields are inconsistent #7757

merged 3 commits into from
Jul 17, 2024

Conversation

klesh
Copy link
Contributor

@klesh klesh commented Jul 17, 2024 •
edited
Loading

Summary

  1. add created_date to _tool_circleci_workflows, renamed stopped_at column to stopped_date
  2. updated_date and created_date in _tool_circileci_pipelines are always empty

Does this close any open issues?

Related to #7750

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug labels Jul 17, 2024
abeizn
abeizn reviewed Jul 17, 2024
View reviewed changes
backend/plugins/circleci/models/migrationscripts/20240717_add_createddate_to_workflow.go Outdated
}

func (*addCreatedStoppedDateToWorkflow) Version() uint64 {
return 20231129211000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20240717xxx?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

abeizn
abeizn approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 17, 2024
@abeizn abeizn merged commit f0be93c into main Jul 17, 2024
10 checks passed
@abeizn abeizn deleted the bugfix-7750-circleci-date-fields branch July 17, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeizn abeizn abeizn approved these changes

Assignees
No one assigned
Labels
component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer pr-type/bug-fix This PR fixes a bug size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klesh @abeizn