Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(framework): update trigger api's request body schema #7888

Merged
merged 3 commits into from
Aug 13, 2024
Merged

fix(framework): update trigger api's request body schema #7888

merged 3 commits into from
Aug 13, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Aug 13, 2024 •
edited
Loading

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
Update trigger api's request body schema, remove skipOnFail and timeAfter.

Does this close any open issues?

Closes #7886

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 13, 2024
@d4x1 d4x1 added needs-cherrypick-v1.0 and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 13, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 13, 2024
@d4x1 d4x1 added pr-type/bug-fix This PR fixes a bug and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 13, 2024
@dosubot dosubot bot added the component/framework This issue or PR relates to the framework label Aug 13, 2024
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 13, 2024
abeizn
abeizn approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 13, 2024
@klesh klesh merged commit 6399854 into main Aug 13, 2024
11 checks passed
@klesh klesh deleted the dev-1 branch August 13, 2024 09:36
github-actions bot pushed a commit that referenced this pull request Aug 13, 2024
@d4x1
fix(framework): update trigger api's request body schema (#7888)
1ba8915 
* fix(framework): update trigger api's request body schema

* fix(framework): fix test errors

* fix(framework): fix test errors
@github-actions github-actions bot mentioned this pull request Aug 13, 2024
Merged
@github-actions GitHub Actions
Copy link

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Aug 13, 2024
d4x1 added a commit that referenced this pull request Aug 13, 2024
@github-actions @d4x1
fix(framework): update trigger api's request body schema (#7888) (#7890)
cb79c9e 
* fix(framework): update trigger api's request body schema

* fix(framework): fix test errors

* fix(framework): fix test errors

Co-authored-by: Lynwee <1507509064@qq.com>
klesh pushed a commit that referenced this pull request Aug 14, 2024
@d4x1 @klesh
fix(framework): update trigger api's request body schema (#7888)
74d54c0 
* fix(framework): update trigger api's request body schema

* fix(framework): fix test errors

* fix(framework): fix test errors
d4x1 added a commit that referenced this pull request Aug 14, 2024
@klesh @d4x1
Fix a couple of "Data too long" errors from sonarqube, jira, etc (#7885)
7e97e43 
* refactor: remove extraction logic from github graphql collector

* fix: pull requests not being updated

* refactor: update github job extractor for single record structure

* refactor: update github issue extractor to extract single record

* refactor: update github deployment extractor to extract single records

* refactor: update github account/release extractor to adopt single record extraction

* docs: add comments

* fix: github issues not being updated

* fix: gitub deployment unit test

* fix: change jira issue component field to text type

* fix: column type should not be parameterized

* fix: #7852 sonarqube issues component field data too long

* fix: change issue.components to text to avoid data too long error

* docs: fix jira issues component tag

* fix: change bitbucket issue components field to text

* fix: change gitee issue components field to text

* fix: change github issue components field to text

* fix: change gitlab issue components field to text

* fix: #7715 Data too long for column 'project_key'

* fix(framework): update trigger api's request body schema (#7888)

* fix(framework): update trigger api's request body schema

* fix(framework): fix test errors

* fix(framework): fix test errors

* test(jira): add e2e test for custom account field in issues (#7894)

* fix: github graphql collectors are not refetching data in incremental mode (#7878)

* refactor: remove extraction logic from github graphql collector

* fix: pull requests not being updated

* refactor: update github job extractor for single record structure

* refactor: update github issue extractor to extract single record

* refactor: update github deployment extractor to extract single records

* refactor: update github account/release extractor to adopt single record extraction

* docs: add comments

* fix: github issues not being updated

* fix: gitub deployment unit test

* fix: github graphql issue collector should order records by CREATED_AT to avoid data missing

* fix: linting

---------

Co-authored-by: Lynwee <1507509064@qq.com>
github-actions bot pushed a commit that referenced this pull request Aug 14, 2024
@klesh @d4x1
Fix a couple of "Data too long" errors from sonarqube, jira, etc (#7885)
f974bda 
* refactor: remove extraction logic from github graphql collector

* fix: pull requests not being updated

* refactor: update github job extractor for single record structure

* refactor: update github issue extractor to extract single record

* refactor: update github deployment extractor to extract single records

* refactor: update github account/release extractor to adopt single record extraction

* docs: add comments

* fix: github issues not being updated

* fix: gitub deployment unit test

* fix: change jira issue component field to text type

* fix: column type should not be parameterized

* fix: #7852 sonarqube issues component field data too long

* fix: change issue.components to text to avoid data too long error

* docs: fix jira issues component tag

* fix: change bitbucket issue components field to text

* fix: change gitee issue components field to text

* fix: change github issue components field to text

* fix: change gitlab issue components field to text

* fix: #7715 Data too long for column 'project_key'

* fix(framework): update trigger api's request body schema (#7888)

* fix(framework): update trigger api's request body schema

* fix(framework): fix test errors

* fix(framework): fix test errors

* test(jira): add e2e test for custom account field in issues (#7894)

* fix: github graphql collectors are not refetching data in incremental mode (#7878)

* refactor: remove extraction logic from github graphql collector

* fix: pull requests not being updated

* refactor: update github job extractor for single record structure

* refactor: update github issue extractor to extract single record

* refactor: update github deployment extractor to extract single records

* refactor: update github account/release extractor to adopt single record extraction

* docs: add comments

* fix: github issues not being updated

* fix: gitub deployment unit test

* fix: github graphql issue collector should order records by CREATED_AT to avoid data missing

* fix: linting

---------

Co-authored-by: Lynwee <1507509064@qq.com>
d4x1 added a commit that referenced this pull request Aug 14, 2024
@github-actions @klesh @d4x1
Fix a couple of "Data too long" errors from sonarqube, jira, etc (#7885…
e2fbbba 
…) (#7898)

* refactor: remove extraction logic from github graphql collector

* fix: pull requests not being updated

* refactor: update github job extractor for single record structure

* refactor: update github issue extractor to extract single record

* refactor: update github deployment extractor to extract single records

* refactor: update github account/release extractor to adopt single record extraction

* docs: add comments

* fix: github issues not being updated

* fix: gitub deployment unit test

* fix: change jira issue component field to text type

* fix: column type should not be parameterized

* fix: #7852 sonarqube issues component field data too long

* fix: change issue.components to text to avoid data too long error

* docs: fix jira issues component tag

* fix: change bitbucket issue components field to text

* fix: change gitee issue components field to text

* fix: change github issue components field to text

* fix: change gitlab issue components field to text

* fix: #7715 Data too long for column 'project_key'

* fix(framework): update trigger api's request body schema (#7888)

* fix(framework): update trigger api's request body schema

* fix(framework): fix test errors

* fix(framework): fix test errors

* test(jira): add e2e test for custom account field in issues (#7894)

* fix: github graphql collectors are not refetching data in incremental mode (#7878)

* refactor: remove extraction logic from github graphql collector

* fix: pull requests not being updated

* refactor: update github job extractor for single record structure

* refactor: update github issue extractor to extract single record

* refactor: update github deployment extractor to extract single records

* refactor: update github account/release extractor to adopt single record extraction

* docs: add comments

* fix: github issues not being updated

* fix: gitub deployment unit test

* fix: github graphql issue collector should order records by CREATED_AT to avoid data missing

* fix: linting

---------

Co-authored-by: Klesh Wong <zhenmian.huang@merico.dev>
Co-authored-by: Lynwee <1507509064@qq.com>
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeizn abeizn abeizn approved these changes

@klesh klesh klesh approved these changes

Assignees
No one assigned
Labels
bot/auto-cherry-pick-completed auto cherry pick completed component/framework This issue or PR relates to the framework lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug][TimeAfter] Bug title The timeAfter parameter in the DevLake sync API isn't functioning as expected.
3 participants
@d4x1 @klesh @abeizn