Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework): add custom pipeline notification service #7920

Merged
merged 3 commits into from
Aug 20, 2024
Merged

feat(framework): add custom pipeline notification service #7920

merged 3 commits into from
Aug 20, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Aug 19, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
Add custom pipeline notification service

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. component/framework This issue or PR relates to the framework pr-type/feature-development This PR is to develop a new feature labels Aug 19, 2024
abeizn
abeizn approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 20, 2024
@abeizn abeizn merged commit e17fc7a into main Aug 20, 2024
11 checks passed
@abeizn abeizn deleted the dev-1 branch August 20, 2024 08:23
@d4x1 d4x1 mentioned this pull request Aug 20, 2024
Merged
d4x1 added a commit that referenced this pull request Aug 20, 2024
@d4x1
cherry pick feat(framework): add custom pipeline notification service #…
a2fffb9 
…7920 to v1.0 (#7924)

* feat(framework): add custom pipeline notification service

* fix(e2e): fix errors
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeizn abeizn abeizn approved these changes

Assignees
No one assigned
Labels
component/framework This issue or PR relates to the framework lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/feature-development This PR is to develop a new feature size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4x1 @abeizn