Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: polish DORA dashboards #7961

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: polish DORA dashboards #7961

merged 1 commit into from
Aug 27, 2024

Conversation

Startrekzky
Copy link
Contributor

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

  1. Update the benchmark of daily in the deployment frequency panel from 7 to 5
  2. Update the 'no data hint' logic of the metric FDTR
  3. Adjust the default color to grey when there's no data

Screenshots

These dashboards are updated:

image

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. component/ext This issue or PR relates to external components, such as Grafana pr-type/refactor This PR refactors existing features labels Aug 27, 2024
@Startrekzky Startrekzky mentioned this pull request Aug 27, 2024
Merged
2 tasks
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 27, 2024
@abeizn abeizn merged commit 11c21ab into apache:main Aug 27, 2024
10 checks passed
Startrekzky added a commit to merico-dev/lake that referenced this pull request Aug 28, 2024
@Startrekzky @merico-devlake
fix: polish DORA dashboards (apache#7961)
eb0f0e7 
Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
@Startrekzky Startrekzky mentioned this pull request Aug 28, 2024
Merged
4 tasks
abeizn pushed a commit that referenced this pull request Aug 28, 2024
@Startrekzky @merico-devlake
fix: polish DORA dashboards (#7961) (#7978)
baca782 
Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
@Startrekzky Startrekzky deleted the update-dora-dashboards branch August 28, 2024 10:02
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeizn abeizn abeizn approved these changes

Assignees
No one assigned
Labels
component/ext This issue or PR relates to external components, such as Grafana lgtm This PR has been approved by a maintainer pr-type/refactor This PR refactors existing features size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Startrekzky @abeizn @merico-devlake