Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gitextractor): support empty repos #7963

Merged
merged 2 commits into from
Aug 27, 2024
Merged

fix(gitextractor): support empty repos #7963

merged 2 commits into from
Aug 27, 2024

Conversation

d4x1
Copy link
Contributor

@d4x1 d4x1 commented Aug 27, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. Support empty repos.
  2. Fix a typo.
  3. Add some debug logs.
  4. Fix missing error message.

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Before fix

image

After fix

image

Normal repos work well

image

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 marked this pull request as ready for review August 27, 2024 08:22
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug labels Aug 27, 2024
abeizn
abeizn approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 27, 2024
@abeizn abeizn merged commit 3f1ac80 into main Aug 27, 2024
10 checks passed
@abeizn abeizn deleted the dev-1 branch August 27, 2024 08:30
github-actions bot pushed a commit that referenced this pull request Aug 27, 2024
@d4x1
fix(gitextractor): support empty repos (#7963)
519cf68 
* fix(gitextractor): support empty repos

* fix(gitextractor): tiny fix
@github-actions github-actions bot mentioned this pull request Aug 27, 2024
Merged
@github-actions GitHub Actions
Copy link

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Aug 27, 2024
d4x1 added a commit that referenced this pull request Aug 27, 2024
@github-actions @d4x1
fix(gitextractor): support empty repos (#7963) (#7964)
cc72500 
* fix(gitextractor): support empty repos

* fix(gitextractor): tiny fix

Co-authored-by: Lynwee <1507509064@qq.com>
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeizn abeizn abeizn approved these changes

Assignees
No one assigned
Labels
bot/auto-cherry-pick-completed auto cherry pick completed component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d4x1 @abeizn