Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: go ci lint #7989

Merged
merged 2 commits into from
Sep 2, 2024
Merged

fix: go ci lint #7989

merged 2 commits into from
Sep 2, 2024

Conversation

abeizn
Copy link
Contributor

@abeizn abeizn commented Sep 2, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

Does this close any open issues?

Closes xx

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. devops Something about CI/CD (devops) pr-type/bug-fix This PR fixes a bug labels Sep 2, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 2, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 2, 2024
@abeizn abeizn merged commit 659f603 into main Sep 2, 2024
12 checks passed
@abeizn abeizn deleted the fix-lint-0902-1 branch September 2, 2024 07:43
github-actions bot pushed a commit that referenced this pull request Sep 2, 2024
@abeizn
fix: go ci lint (#7989)
1d16340 
* fix: go ci lint

* refactor: update go mod
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Sep 2, 2024
@abeizn abeizn mentioned this pull request Sep 2, 2024
Closed
abeizn added a commit that referenced this pull request Sep 2, 2024
@github-actions @abeizn
fix: go ci lint (#7989) (#7990)
ffc5a09 
* fix: go ci lint

* refactor: update go mod

Co-authored-by: abeizn <zikuan.an@merico.dev>
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4x1 d4x1 d4x1 approved these changes

Assignees
No one assigned
Labels
bot/auto-cherry-pick-completed auto cherry pick completed devops Something about CI/CD (devops) lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abeizn @d4x1