Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sql query PostgreSQL compatible #8163

Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: make sql query PostgreSQL compatible #8163

merged 1 commit into from
Nov 6, 2024

Conversation

Tonkonozhenko
Copy link
Contributor

@Tonkonozhenko Tonkonozhenko commented Oct 29, 2024 •
edited
Loading

Summary

Make SQL queries work in PostgreSQL

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug labels Oct 29, 2024
@Tonkonozhenko Tonkonozhenko changed the title Fix sql string escaping fix: make sql query PostgreSQL compatible Oct 29, 2024
klesh
klesh approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Would you like to create another PR to the branch release-v1.0 so it can be released sooner?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2024
@Tonkonozhenko Tonkonozhenko mentioned this pull request Oct 30, 2024
Merged
@Tonkonozhenko
Copy link
Contributor Author

@klesh done: #8167

@klesh klesh merged commit 3a7acd6 into apache:main Nov 6, 2024
12 of 13 checks passed
@vateseeb vateseeb mentioned this pull request Dec 2, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klesh klesh klesh approved these changes

Assignees
No one assigned
Labels
component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer pr-type/bug-fix This PR fixes a bug size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tonkonozhenko @klesh