-
Notifications
You must be signed in to change notification settings - Fork 19.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: make contentToOption
totally optional
#13139
Conversation
In #13086 @pissang has raised an issue. He says that PR will make option not refreshed if user didn't provide The key points here are:
|
Hi @easonyq, thanks for the detailed explanation. I think the scenario you described is complete enough. |
Thanks for @pissang 's review. I've applied another patch. |
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Brief Information
This pull request is in the type of:
What does this PR do?
Fix #13031 and #13086
Fixed issues
#13031 has described such a situation that user has provided
optionToContent
function while has not provided the correspondingcontentToOption
function.If we think echarts should also work well in this situation, we need to make
contentToOption
function totally optional. (In other words, if user hasn't provided it, bugs like missing series data or showing a list ofundefined
should not happen.)Details
Before: What was the problem?
If user provide
optionToContent
function but has not providedcontentToOption
function, press 'refresh' will lose data and make a list ofundefined
displayed.After: How is it fixed in this PR?
Even user has not provided
contentToOption
function, by pressing 'refresh' button also works well.Usage
Are there any API changes?
No
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information