Skip to content

Commit

Permalink
[VL] Fix bug where session config is lost when benchmark is enabled (#…
Browse files Browse the repository at this point in the history
…5054)

It's a quick bug fix.

unordered_map::merge removes the duplicated items from source.
  • Loading branch information
FelixYBW authored Mar 21, 2024
1 parent e621e52 commit e317e4d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion cpp/velox/compute/VeloxRuntime.cc
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,10 @@ std::unique_ptr<ColumnarBatchSerializer> VeloxRuntime::createColumnarBatchSerial
void VeloxRuntime::dumpConf(const std::string& path) {
auto backendConf = VeloxBackend::get()->getBackendConf();
auto allConf = backendConf;
allConf.merge(confMap_);

for (const auto& pair : confMap_) {
allConf.insert_or_assign(pair.first, pair.second);
}

// Open file "velox.conf" for writing, automatically creating it if it doesn't exist,
// or overwriting it if it does.
Expand Down

0 comments on commit e317e4d

Please sign in to comment.