Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-1389][CH] Fix ORC/Parquet column name case-insensitive matching issue #1390

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

taiyang-li
Copy link
Contributor

@taiyang-li taiyang-li commented Apr 18, 2023

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #1389)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@taiyang-li taiyang-li changed the title [Gluten-1389][ClickHouse-Backend]Fix ORC/Parquet column name case-insensitive matching issue [GLUTEN-1389][ClickHouse-Backend]Fix ORC/Parquet column name case-insensitive matching issue Apr 18, 2023
@github-actions
Copy link

#1389

@PHILO-HE PHILO-HE changed the title [GLUTEN-1389][ClickHouse-Backend]Fix ORC/Parquet column name case-insensitive matching issue [GLUTEN-1389][CH] Fix ORC/Parquet column name case-insensitive matching issue Apr 19, 2023
@PHILO-HE
Copy link
Contributor

Just simplified the title with CH representing ClickHouse-Backend.

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

1 similar comment
@liuneng1994
Copy link
Contributor

Run Gluten Clickhouse CI

Copy link
Contributor

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORC/Parquet column name case-insensitive matching issue
3 participants