[VL][CI] update docker build script #3904
Conversation
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
|
Run Gluten Clickhouse CI |
zhouyuan
changed the title
zhouyuan
changed the title
zhouyuan
changed the title
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
zhouyuan
force-pushed
the
wip_cent7_static
branch
from
4349fb3
to
956c545
Compare
| @@ -93,6 +93,7 @@ RUN EXTRA_MAVEN_OPTIONS=$(cat ~/.gluten-mvn-options) \ | |||
| DEPS_INSTALL_SCRIPT=$(cat ~/.gluten-deps-install-script) \ | |||
| && cd /opt/gluten \ | |||
| && bash -c "$DEPS_INSTALL_SCRIPT" \ | |||
| && bash -c "mvn clean install $GLUTEN_MAVEN_OPTIONS $EXTRA_MAVEN_OPTIONS" | |||
| && bash -c "mvn clean install $GLUTEN_MAVEN_OPTIONS $EXTRA_MAVEN_OPTIONS" \ | |||
| && bash -c "mv ep/build-velox/build/velox_ep /opt/velox" | |||
There was a problem hiding this comment.
this is to save velox build to /opt
There was a problem hiding this comment.
Minor: This would make libvelox.so unable to locate symbol source when debug build is enabled. Is there any reason to do it?
There was a problem hiding this comment.
I'm preparing the pre-built docker image for GHA. In GHA The velox home is set to /opt/velox. by save the pre-built velox to /opt/velox can help to reuse the velox build before rebase happen. We could also try to copy the velox folder to /opt/ but it will occupy too many disk spaces
https://github.com/oap-project/gluten/blob/main/.github/workflows/velox_be.yml#L59
A proper way is to create separate docker files for dev, CI image purpose - we could follow up on this
| && cd /opt/gluten \ | ||
| && bash -c "$DEPS_INSTALL_SCRIPT" \ | ||
| && bash -c "mvn clean install $GLUTEN_MAVEN_OPTIONS $EXTRA_MAVEN_OPTIONS" \ | ||
| && bash -c "mv ep/build-velox/build/velox_ep /opt/velox" |
There was a problem hiding this comment.
this is to save velox build to /opt
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
|
Run Gluten Clickhouse CI |
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
What changes were proposed in this pull request?
this patch updates the docker build script for ubuntu/centos.
do not run setup scripts on centos 7 for static build, which is not necessary.
How was this patch tested?
pass GHA