Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Fix VeloxTPCHV1BhjSuite and VeloxTPCHV2Suite useV1SourceList #3930

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

liujiayi771
Copy link
Contributor

What changes were proposed in this pull request?

V1 should set spark.sql.sources.useV1SourceList="parquet"
V2 should set spark.sql.sources.useV1SourceList=""

How was this patch tested?

Exists CI.

Copy link

github-actions bot commented Dec 5, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@liujiayi771
Copy link
Contributor Author

@PHILO-HE @rui-mo Is there a problem with the setting of spark.sql.sources.useV1SourceList in the test cases for V1 and V2 here?

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Dec 6, 2023

Looks good! Thanks!

@PHILO-HE PHILO-HE merged commit 06b9d47 into apache:main Dec 6, 2023
15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3930_time.csv log/native_master_12_05_2023_a46243420_time.csv difference percentage
q1 33.55 34.72 1.166 103.47%
q2 25.73 25.00 -0.724 97.19%
q3 37.90 37.98 0.078 100.21%
q4 37.29 38.25 0.967 102.59%
q5 72.88 72.06 -0.821 98.87%
q6 7.14 5.37 -1.776 75.13%
q7 86.17 82.30 -3.876 95.50%
q8 87.06 86.96 -0.106 99.88%
q9 127.22 126.92 -0.295 99.77%
q10 45.38 45.43 0.047 100.10%
q11 19.88 20.31 0.430 102.16%
q12 27.87 27.02 -0.849 96.95%
q13 46.16 47.15 0.990 102.14%
q14 15.98 19.01 3.029 118.95%
q15 27.63 29.59 1.957 107.08%
q16 15.81 15.81 0.002 100.02%
q17 101.91 103.87 1.966 101.93%
q18 150.74 150.70 -0.042 99.97%
q19 13.22 14.53 1.304 109.86%
q20 27.42 28.18 0.764 102.79%
q21 224.83 223.72 -1.110 99.51%
q22 13.18 13.17 -0.006 99.96%
total 1244.95 1248.05 3.095 100.25%

@liujiayi771 liujiayi771 deleted the tpch-test branch December 6, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants