Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Fix boost installation issue and remove useless QueryCtx #4850

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Mar 5, 2024

What changes were proposed in this pull request?

This is a followup for velox code rebase 2024_03_04.

How was this patch tested?

Internal Jenkins job.

Copy link

github-actions bot commented Mar 5, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4850_time.csv log/native_master_03_03_2024_6b5ee6971_time.csv difference percentage
q1 35.60 36.61 1.002 102.82%
q2 24.28 24.50 0.212 100.87%
q3 37.37 39.42 2.052 105.49%
q4 38.37 38.53 0.155 100.40%
q5 71.70 70.78 -0.917 98.72%
q6 5.41 7.30 1.893 135.00%
q7 83.37 84.97 1.595 101.91%
q8 86.60 84.52 -2.081 97.60%
q9 121.65 121.76 0.105 100.09%
q10 43.70 44.77 1.074 102.46%
q11 20.43 20.74 0.309 101.51%
q12 24.76 29.46 4.702 118.99%
q13 44.67 45.96 1.288 102.88%
q14 15.25 21.41 6.158 140.38%
q15 29.66 27.97 -1.691 94.30%
q16 13.41 13.22 -0.190 98.59%
q17 101.34 103.13 1.784 101.76%
q18 144.29 146.21 1.917 101.33%
q19 12.73 13.66 0.932 107.32%
q20 25.66 26.57 0.915 103.57%
q21 226.51 225.15 -1.365 99.40%
q22 13.96 13.79 -0.174 98.75%
total 1220.74 1240.41 19.676 101.61%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4850_time.csv log/native_master_03_03_2024_6b5ee6971_time.csv difference percentage
q1 36.24 36.61 0.369 101.02%
q2 24.42 24.50 0.079 100.32%
q3 37.52 39.42 1.906 105.08%
q4 37.82 38.53 0.714 101.89%
q5 72.57 70.78 -1.788 97.54%
q6 7.29 7.30 0.012 100.17%
q7 84.22 84.97 0.742 100.88%
q8 86.76 84.52 -2.246 97.41%
q9 124.37 121.76 -2.616 97.90%
q10 44.08 44.77 0.693 101.57%
q11 20.47 20.74 0.274 101.34%
q12 28.94 29.46 0.517 101.79%
q13 44.95 45.96 1.016 102.26%
q14 20.27 21.41 1.138 105.61%
q15 29.06 27.97 -1.087 96.26%
q16 14.44 13.22 -1.213 91.60%
q17 101.90 103.13 1.224 101.20%
q18 145.31 146.21 0.898 100.62%
q19 12.69 13.66 0.967 107.61%
q20 25.48 26.57 1.092 104.29%
q21 226.26 225.15 -1.107 99.51%
q22 14.77 13.79 -0.982 93.35%
total 1239.81 1240.41 0.604 100.05%

@@ -126,13 +129,14 @@ function process_setup_centos8 {
fi
# make this function Reentrant
git checkout scripts/setup-centos8.sh
sed -i "s/boostorg.jfrog.io\/artifactory\/main\/release\/1.72.0\/source\/boost_1_72_0.tar.gz/src.fedoraproject.org\/repo\/pkgs\/boost\/boost_1_72_0-snapshot.tar.gz\/sha512\/b91d96e0fd76cdfb2accadedde85a7d005d7f8ccdfde50c7f195bd5ea1f0c203520d5dac1fca33f38f20ff484f8400303226d6febb31f644ebb4d9809f91088a\/boost_1_72_0-snapshot.tar.gz/" scripts/setup-centos8.sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been upgraded in upstream velox and a github repo link is being used to download.

@PHILO-HE PHILO-HE merged commit d09583a into apache:main Mar 5, 2024
18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_4850_time.csv log/native_master_03_03_2024_6b5ee6971_time.csv difference percentage
q1 36.69 36.61 -0.084 99.77%
q2 24.45 24.50 0.050 100.21%
q3 37.91 39.42 1.515 104.00%
q4 39.55 38.53 -1.017 97.43%
q5 70.42 70.78 0.358 100.51%
q6 5.45 7.30 1.850 133.95%
q7 84.30 84.97 0.671 100.80%
q8 86.00 84.52 -1.487 98.27%
q9 124.36 121.76 -2.604 97.91%
q10 42.44 44.77 2.328 105.48%
q11 20.68 20.74 0.057 100.28%
q12 28.22 29.46 1.235 104.37%
q13 45.13 45.96 0.831 101.84%
q14 16.60 21.41 4.813 129.00%
q15 28.98 27.97 -1.011 96.51%
q16 14.44 13.22 -1.212 91.60%
q17 102.84 103.13 0.288 100.28%
q18 145.98 146.21 0.231 100.16%
q19 12.69 13.66 0.974 107.68%
q20 25.79 26.57 0.777 103.01%
q21 225.70 225.15 -0.553 99.75%
q22 13.45 13.79 0.339 102.52%
total 1232.07 1240.41 8.349 100.68%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants