[VL] Support lead/lag window function with negative input offset #5026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
PHILO-HE
force-pushed
the
fix-lead-lag-minus-offset
branch
from
c776eb6 to
c616442
Compare
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
PHILO-HE
force-pushed
the
fix-lead-lag-minus-offset
branch
from
bbaecbd to
7cecd46
Compare
|
Run Gluten Clickhouse CI |
|
@ulysses-you, could you please review this pr? Thanks! |
PHILO-HE
force-pushed
the
fix-lead-lag-minus-offset
branch
from
7cecd46 to
84f9d7d
Compare
|
Run Gluten Clickhouse CI |
ulysses-you
approved these changes
Mar 20, 2024
WangGuangxin
pushed a commit
to WangGuangxin/gluten
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark lead/lag window functions are quite similar. One can be converted to the other by simply putting a minus for offset. For example,
lag(c1, -1)can be converted tolead(c1, 1). Since Velox doesn't support negative offset, we can just do a conversion to meet velox's requirement.How was this patch tested?
Existing Spark UTs and a new added test.