[GLUTEN-5335][VL] Use common name for both celeborn and uniffle #5385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
@jackylee-ch @PHILO-HE PTAL |
|
Maybe we should change the profile in pom.xml from |
|
also cc @Yohahaha |
|
cc @kerwin-zk |
kerwin-zk
reviewed
Apr 15, 2024
cpp/core/jni/JniCommon.h
Outdated
| public: | ||
| CelebornClient(JavaVM* vm, jobject javaCelebornShuffleWriter, jmethodID javaCelebornPushPartitionDataMethod) | ||
| : vm_(vm), javaCelebornPushPartitionData_(javaCelebornPushPartitionDataMethod) { | ||
| JavaRssClient(JavaVM* vm, jobject javaShuffleWriter, jmethodID javaPushPartitionDataMethod) |
There was a problem hiding this comment.
javaShuffleWriter -> javaRssShuffleWriter
cpp/core/jni/JniCommon.h
Outdated
| } | ||
|
|
||
| void stop() override {} | ||
|
|
||
| private: | ||
| JavaVM* vm_; | ||
| jobject javaCelebornShuffleWriter_; | ||
| jmethodID javaCelebornPushPartitionData_; | ||
| jobject javaShuffleWriter_; |
There was a problem hiding this comment.
javaShuffleWriter_ -> javaRssShuffleWriter_
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
jackylee-ch
approved these changes
Apr 15, 2024
PHILO-HE
reviewed
Apr 15, 2024
There was a problem hiding this comment.
@kerwin-zk, please take a look again. If it looks good to you, please approve it. Thanks!
|
Thanks for your review. @PHILO-HE @kerwin-zk @Yohahaha |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
loneylee
added a commit
to loneylee/gluten
that referenced
this pull request
Apr 16, 2024
…le (apache#5385)" This reverts commit 9c15d2e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#5335
How was this patch tested?
integration test