Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][VL] Remove duplicate mvn packages #6560

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

wForget
Copy link
Member

@wForget wForget commented Jul 23, 2024

What changes were proposed in this pull request?

The mvn package commands have been executed in buildbundle-veloxbe.sh, so we need to remove the duplicate mvn package commands in package-vcpkg.sh.

How was this patch tested?

manual test

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@wForget wForget changed the title [MINOR] Remove duplicate mvn packages [MINOR][VL] Remove duplicate mvn packages Jul 23, 2024
Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jackylee-ch jackylee-ch merged commit 4ef147b into apache:main Jul 24, 2024
40 checks passed
weiting-chen pushed a commit to weiting-chen/gluten that referenced this pull request Nov 18, 2024
weiting-chen added a commit that referenced this pull request Nov 20, 2024
* [MINOR] Remove duplicate mvn packages (#6560)

* [VL] Improve package scripts (#6569)

* [GLUTEN-6569][VL] Delete unnecessary gcc9 enabling from package script (#6730)

* [GLUTEN-7118][VL] Fix duckdb target issue when vcpkg is enabled (#7117)

---------

Co-authored-by: Zhen Wang <643348094@qq.com>
Co-authored-by: PHILO-HE <feilong.he@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants