Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-7014][CH] Fix: different results from get_json_object #7034

Merged
merged 1 commit into from
Aug 29, 2024
Merged

[GLUTEN-7014][CH] Fix: different results from get_json_object #7034

merged 1 commit into from
Aug 29, 2024

Conversation

lgbo-ustc
Copy link
Contributor

@lgbo-ustc lgbo-ustc commented Aug 27, 2024 •
edited
Loading

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

Fixes: #7014

Fix following case

select get_json_object('{"a":"\\\"b", "x":"u0001}Uûu0010Jw\\\"<洫C"}\0', '$.a');

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

unit tests

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions GitHub Actions
Copy link

#7014

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

1 similar comment
@lgbo-ustc
Copy link
Contributor Author

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@lgbo-ustc lgbo-ustc requested a review from liuneng1994 August 28, 2024 04:34
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@lgbo-ustc lgbo-ustc requested a review from exmy August 28, 2024 07:54
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions github-actions bot added the CORE works for Gluten Core label Aug 28, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@lgbo-ustc lgbo-ustc merged commit 96130d1 into apache:main Aug 29, 2024
45 checks passed
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
@lgbo-ustc
different results from get_json_object with comparison to vanilla (ap…
eb4e7bd 
…ache#7034)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinyhZou KevinyhZou KevinyhZou left review comments

@liuneng1994 liuneng1994 liuneng1994 left review comments

@exmy exmy exmy approved these changes

Assignees
No one assigned
Labels
CLICKHOUSE CORE works for Gluten Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CH] Different result from get_json_object
4 participants
@lgbo-ustc @liuneng1994 @exmy @KevinyhZou