Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7037][VL] Add dwarf dependency to folly when building with vcpkg #7038

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Z1Wu
Copy link
Contributor

@Z1Wu Z1Wu commented Aug 27, 2024

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #ISSUE-ID)

fix issue : #7037

Adding libdwarf dependency in folly vcpkg.json manifest to enable velox to get symbol from address when throw exception.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

image

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions github-actions bot added the BUILD label Aug 27, 2024
Copy link

#7037

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix!

@zhztheplayer
Copy link
Member

zhztheplayer commented Aug 28, 2024

@Z1Wu Can you verify whether GitHub CI is printing valid stacks now?

cc @PHILO-HE

@zhztheplayer zhztheplayer changed the title [GLUTEN-7037][VL] add dwarf dependency to folly when building with vcpkg [GLUTEN-7037][VL] Add dwarf dependency to folly when building with vcpkg Aug 28, 2024
@PHILO-HE
Copy link
Contributor

@Z1Wu Can you verify whether GitHub CI is printing valid stacks now?

cc @PHILO-HE

@zhztheplayer, I have verified. It works.

Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE PHILO-HE merged commit 65cdf22 into apache:main Aug 28, 2024
42 checks passed
wForget pushed a commit to wForget/gluten that referenced this pull request Oct 28, 2024
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants