[VL] RAS: Avoid adding R2C whose schema contains complex data types #7229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
zhztheplayer
changed the title
|
Run Gluten Clickhouse CI |
| case r2c: RowToColumnarExecBase if hasComplexTypes(r2c.schema) => | ||
| // Avoid moving computation back to native when transition has complex types in schema. | ||
| // Such transitions are observed to be extreme expensive as of now. | ||
| Long.MaxValue |
There was a problem hiding this comment.
Can we add a more reasonable value to the cost? How can we measure the operator cost now?
There was a problem hiding this comment.
We can use it as a temp solution. The r2c is very expensive.
There was a problem hiding this comment.
Yes. it's just a heuristic as a temp solution from query optimizer side.
|
Run Gluten Clickhouse CI |
jinchengchenghh
previously approved these changes
Sep 13, 2024
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
temp fix of #7223 |
JkSelf
approved these changes
Sep 14, 2024
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's observed Velox R2C becomes expensive when containing complex data types as input. Add a coster in rough cost model to address the issue.
To enable rough cost model: