[VL] Enhance spill log readability #7300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
FelixYBW
previously approved these changes
Sep 20, 2024
Comment on lines
241
to
242
| LOG(WARNING) << logPrefix << "Spill is requested on a task " << task_->taskId() | ||
| << " that has non-zero running threads, which is not currently supported. Skipping."; |
There was a problem hiding this comment.
I think this case is expected but just rare. Can we keep it in INFO? We can lower the verbose level anyway.
| return shrunken; | ||
| } | ||
| int64_t remaining = size - shrunken; | ||
| LOG(INFO) << logPrefix << "Trying to request spill for " << remaining << " bytes..."; | ||
| auto* mm = memoryManager_->getMemoryManager(); | ||
| LOG(INFO) << logPrefix << "Trying to request spill for " << velox::succinctBytes(remaining); |
There was a problem hiding this comment.
nit: With the punctuation mark removed the log could look a bit ugly. E.g.,
W20240920 11:38:50.542661 20191 HashBuild.cpp:1052] Trying to request spill for 1MB
zhztheplayer
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.