Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT][C++] Use shared_ptr in all readers and writers #281

Merged
merged 10 commits into from
Nov 28, 2023

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Nov 14, 2023

Proposed changes

  • Add Make static method to the reader and writers (include collection and builder) to return shared ptr of object, provide a better constructor of the reader and writer.
    benefit:
    • avoid memory copy.
    • provide some check in Make function
  • Update the test and document with Make construct method.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close issue #280

@acezen acezen force-pushed the 280-shared-ptr-in-reader-writer branch from 3a9dd8a to 8706832 Compare November 28, 2023 11:06
@acezen acezen marked this pull request as ready for review November 28, 2023 11:06
@acezen acezen changed the title [FEAT][C++] Use shared ptr in all reader and writer [FEAT][C++] Use shared_ptr in all readers and writers Nov 28, 2023
@acezen acezen merged commit 536c44d into apache:main Nov 28, 2023
@acezen acezen deleted the 280-shared-ptr-in-reader-writer branch November 28, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant