-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement][Doc] Provide an implementation status page to indicate libraries status of format implementation support #373
Conversation
Just a small suggestion, related to Spark/PySpark. Because we are going to provide the support of multiple Spark/PySpark versions, I would suggest having the table like, for example:
Because it is important not just know the supported GAR version but also the version of Spark on which the GraphAr Spark will work. |
Thanks for the suggestion, Sem. Yes, it's better to provide a table of supported Spark version too. I will add such a page in this Pull Request too. |
I have added tables for libraries to provide version compatibility. @SemyonSinchenko @Thespica Can you help to complement the Java and PySpark part? |
@acezen what do you think about publishing this table in releases too? |
You mean the release notes? I think it's a good place to put the version compatibility table. |
…libraries status of format implementation support Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
109788a
to
03912eb
Compare
hi,@acezen. Could we add some information about supported readers/writers? Also, highlight advanced features like validation and filter pushdown? |
I will post the version compatibility table to release note after PR been merged. |
The reader/ writers implementation are quite different between C++ and Scala/Python. the C++ library has low level to high level reader/writer, and mainly implement with arrow. The Scala library aims to Spark DataFrame. I'm not sure we can show the status like format implementation. |
BTW, I think format implementation are mainly about the meta-info implementation. The reader and writer can put to another document page. We should create a discussion topic to discuss this problem. |
Maybe a top-level overview of reader/writer support across C++ and Scala/Python, emphasizing the integration with Arrow for C++ and Spark DataFrame for Scala, would be beneficial. We can include a status summary and provide a link to the API documentation for those seeking more in-depth information. Shall we proceed with this approach? |
Sounds reasonable, I can draft a status of reader/writer with this approach. |
hi, @lixueclaire , after add some draft to the status, I'm still thinking it's a little weird that put reader/writer implementation and format implementation together. So I suggest we can add another document to describe the reader/writer implementation. And this change can only contain the format implementation. |
Understood, notice that you put this page under format, I think it is ok. We could include the status of reader/writer implementations in the libraries' documentation later. |
GraphAr spark: Java 1.8 and 11, Scala 2.12.x, Hadoop 3, Spark 3.2.2 and 3.3.4 (we did not test PySpark against 3.3.4 yet) |
Updated, please take a look again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…libraries status of format implementation support
Proposed changes
This changes add some tables to indicate the format implementation status.
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
close #352
related #362