Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor][Spark] Add SPARK_TESTING variable to increse tests performance #405

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

SemyonSinchenko
Copy link
Member

Proposed changes

As described in #404

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

I cannot see dramatic changes in performance (spark 3.3, spark 3.2), but I can guess that in the future versions of spark more and more things will be disabled/simplified when it is turned on. On spark 3.4/3.5 performance improvement should be significant.

 On branch main
 Your branch is up to date with 'origin/main'.

 Changes to be committed:
	modified:   .github/workflows/spark.yaml
	modified:   pyspark/Makefile
@SemyonSinchenko SemyonSinchenko requested a review from acezen March 16, 2024 16:50
@SemyonSinchenko SemyonSinchenko self-assigned this Mar 16, 2024
Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SemyonSinchenko SemyonSinchenko merged commit 706f0b5 into apache:main Mar 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants