Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Reorganize the documents to adapt website building #448

Merged
merged 19 commits into from
Apr 11, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Apr 11, 2024

Proposed changes

Since we have created a repository incubator-graphar-website as our website repo, we should clean the original website page related code from here and only remain the dev documents of the project core(including format, libraries) . So the changes of this Pull Request includes:

  • Remove the website page related code.
  • Convert the dev documents from RST to MarkDown and reorganize them.
  • Refine the Docs CI base on the website building workflow.

The website now looks like:
截屏2024-04-11 15 11 47
截屏2024-04-11 15 55 34

Further comments

related #432

@acezen acezen marked this pull request as ready for review April 11, 2024 04:03
@acezen acezen marked this pull request as draft April 11, 2024 05:22
@acezen acezen changed the title [Docs] Reorg the documents to adapt website building [Docs] Reorganize the documents to adapt website building Apr 11, 2024
@acezen acezen marked this pull request as ready for review April 11, 2024 07:12
@acezen
Copy link
Contributor Author

acezen commented Apr 11, 2024

cc/ @lixueclaire @Thespica @SemyonSinchenko This pull request make a lot of change to the document, may need your review.

docs/libraries/pyspark/how-to.md Outdated Show resolved Hide resolved
docs/libraries/pyspark/how-to.md Outdated Show resolved Hide resolved
docs/libraries/pyspark/how-to.md Outdated Show resolved Hide resolved
docs/libraries/pyspark/how-to.md Outdated Show resolved Hide resolved
docs/libraries/pyspark/how-to.md Outdated Show resolved Hide resolved
docs/libraries/pyspark/how-to.md Outdated Show resolved Hide resolved
docs/libraries/pyspark/pyspark.md Outdated Show resolved Hide resolved
docs/libraries/spark/spark.md Outdated Show resolved Hide resolved
docs/libraries/spark/spark.md Outdated Show resolved Hide resolved
@acezen
Copy link
Contributor Author

acezen commented Apr 11, 2024

The path has been replaced with relative path, and I add a TODO for add markdown lint and typo check CI, please review again, thanks~

Copy link
Member

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I checked only spark/pyspark part.

@Thespica
Copy link
Contributor

Thespica commented Apr 11, 2024

Hi, @acezen the change itself is LGTM.

But when I try to build locally and take a look, I find it a little bit bothering. Can you write some letters that teach how to build documents locally in docs/README.md or docs for developers?

@acezen
Copy link
Contributor Author

acezen commented Apr 11, 2024

Hi, @acezen the change itself is LGTM.

But when I try to build locally and take a look, I find it a little bit bothering. Can you write some letters that teach how to build documents locally in docs/README.md or docs for developers?

hi,@Thespica, I have put the instruction how to build docs in apache-incubator-website README(they share the same process) and would merge after this PR. The docs/README would have a link to it.

@acezen acezen merged commit 36dbcbf into apache:main Apr 11, 2024
2 checks passed
@acezen acezen deleted the 432-reorg-docs branch April 11, 2024 14:49
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
## Proposed changes
Since we have created a repository [incubator-graphar-website](https://github.com/apache/incubator-graphar-website) as our website repo, we should clean the original website page related code from here and only remain the dev documents of the project core(including format, libraries) . So the changes of this Pull Request includes:
- Remove the website page related code.
- Convert the dev documents from RST to MarkDown and reorganize them.
- Refine the Docs CI base on the website building workflow.

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants