Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(c++): move the result.hpp third-party dependency from external directory to third-party directory #462

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Apr 23, 2024

Reason for this PR

as issue #461 describe

What changes are included in this PR?

move the result.hpp to thirdparty

Are these changes tested?

yes

Are there any user-facing changes?

No

…irectory to third-party directory

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen acezen requested a review from lixueclaire April 23, 2024 07:44
@acezen acezen changed the title feat(c++): move the result.hpp third-party dependency from external d… feat(c++): move the result.hpp third-party dependency from external directory to third-party directory Apr 24, 2024
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit 0682b0d into apache:main Apr 24, 2024
3 checks passed
@acezen acezen deleted the 461-move-result-hpp-to-third-party-dir branch April 24, 2024 07:41
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
…irectory to third-party directory (apache#462)

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants