Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): Add aggregator POM for java and spark library to manage the dependency #469

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Apr 29, 2024

Reason for this PR

as #468 describes,
adding aggregator POM for java and spark library to easy manage the dependency

What changes are included in this PR?

add aggregator pom

Are these changes tested?

yes

Are there any user-facing changes?

no

acezen added 3 commits April 29, 2024 15:16
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen acezen marked this pull request as ready for review April 30, 2024 02:18
@acezen
Copy link
Contributor Author

acezen commented Apr 30, 2024

Hi, @SemyonSinchenko @Thespica I would like to get some advice about put the spark and java libraries to a directory like maven-projects next step, that would make the code structure clear and easy for developer to split the libraries into modules.

Copy link
Contributor

@Thespica Thespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@acezen acezen merged commit e89829b into apache:main Apr 30, 2024
5 checks passed
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
…he dependency (apache#469)



---------

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants