feat(c++)!: change the header folder and library name from gar to graphar
#477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
lixueclaire
approved these changes
May 10, 2024
I have checked the docs and there is no |
The document has been updated ( |
Thanks for updating that. It looks that this PR can be merged now. |
Elssky
pushed a commit
to Elssky/incubator-graphar
that referenced
this pull request
Oct 8, 2024
…graphar` (apache#477) ### Reason for this PR as issue apache#476 describe ### What changes are included in this PR? - change the header folder to include/graphar - change the generated library to graphar - update the related document and code. ### Are these changes tested? covered by existing tests. ### Are there any user-facing changes? yes **BREAKING CHANGE: This change make the header include sentence from include gar/ to include graphar/ and link library from gar to graphar** --------- Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
as issue #476 describe
What changes are included in this PR?
include/graphargrapharAre these changes tested?
covered by existing tests.
Are there any user-facing changes?
yes
BREAKING CHANGE: This change make the header include sentence from
include gar/to include graphar/ and link library fromgartographar