Feat(CI): Use environment variable to specify the location of testing data #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi， @lixueclaire @SemyonSinchenko ， This PR may need your review, thanks. |
… data Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com> Fix the format and lint Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
acezen
force-pushed
the
510-remove-testing-submodule
branch
from
d0440d3 to
79e7cff
Compare
|
|
||
| ```bash | ||
| $ git clone https://github.com/apache/incubator-graphar-testing.git testing # download the testing data | ||
| $ GAR_TEST_DATA=${PWD}/testing ctest |
There was a problem hiding this comment.
I would recommend to create a folder dev/ and provide bash/python scripts for downloading the data and set up all the variables. Like download_test_data.sh, etc. We can do it in a separate PR. It is done like this in spark and I found it very user-friendly.
There was a problem hiding this comment.
The suggestion is great, I can do it in the PR #507 .
SemyonSinchenko
approved these changes
Jun 4, 2024
Elssky
pushed a commit
to Elssky/incubator-graphar
that referenced
this pull request
Oct 8, 2024
… data (apache#512) Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
as issue #510 describes, since the released source code tarball would not contains the submodules, to make the test work with tarball, it's better to deprecate testing data submodule and use developer setting environment variable to indicate the location of testing data.
What changes are included in this PR?
Are these changes tested?
already tested by current test case.
Are there any user-facing changes?
no