Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add CHANGELOG.md #513

Merged
merged 2 commits into from
Jun 12, 2024
Merged

chore: Add CHANGELOG.md #513

merged 2 commits into from
Jun 12, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Jun 5, 2024

Reason for this PR

Add CHANGELOG.md to project to to document all changes made to the project.

What changes are included in this PR?

  • Add CHANGELOG.md
  • add changes of v0.1.0 to v0.11.4 to CHANGELOG.md

Are these changes tested?

Are there any user-facing changes?

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@SemyonSinchenko
Copy link
Member

Are you sure that we need to do it manually? Because google's release-please action can automate it. And this action is distributed under Apache 2.0

@acezen
Copy link
Contributor Author

acezen commented Jun 6, 2024

Are you sure that we need to do it manually? Because google's release-please action can automate it. And this action is distributed under Apache 2.0

The action seems great, I think we can automate it in our future releases.

@SemyonSinchenko
Copy link
Member

The action seems great, I think we can automate it in our future releases.

I mean should we check the format of generated CHANGELOG.md by this action and try to align the current changes to the same format?

@acezen
Copy link
Contributor Author

acezen commented Jun 11, 2024

The action seems great, I think we can automate it in our future releases.

I mean should we check the format of generated CHANGELOG.md by this action and try to align the current changes to the same format?

the release-please application seems need to use the github_token but apache only provide tokens for specified application, see doc. It seems that we have to update the CHANGELOG.md manually.

@SemyonSinchenko
Copy link
Member

I see. Thanks for the explanation @acezen
LGTM, approved

@acezen acezen merged commit ff057cf into apache:main Jun 12, 2024
1 check passed
@acezen acezen deleted the add-changelog branch June 12, 2024 02:47
SemyonSinchenko added a commit that referenced this pull request Jun 13, 2024
* feat(spark): Refactoring datasources (#514)

### Reason for this PR
By moving datasources under `org.apache.spark.sql` we are able to access private Spark API. Last time when I was trying to fully migrate datasources to V2 it was a blocker. Detailed motivation is in #493 

### What changes are included in this PR?
Mostly refactoring.

### Are these changes tested?
Unit tests are passed

I manually checked the generated JARs:
![image](https://github.com/apache/incubator-graphar/assets/29755009/1b094516-88b1-490a-a2ea-8dcd092a3b1d)

### Are there any user-facing changes?
Mostly not because `GarDataSource` was left under the same package.


Close #493

* feat(dev): Add release and verify scripts (#507)

Reason for this PR
Add scripts for developer or release manager to easily release version or verify a version.

What changes are included in this PR?
Add release and verify scripts
related document is updated to website, see Update the release and verify document, and add development document incubator-graphar-website#18
Are these changes tested?
yes

Are there any user-facing changes?
no
---------

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* chore: Bump to version v0.12.0 (Round 1) (#517)


Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* chore: Add CHANGELOG.md (#513)


Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* Introduce buf

- v2
- buf.gen
- buf

 On branch format-definition-dev
 Your branch is up to date with 'origin/format-definition-dev'.

 Changes to be committed:
	new file:   buf.gen.yaml
	new file:   buf.yaml
	modified:   format/adjacent_list.proto
	modified:   format/edge_info.proto
	modified:   format/graph_info.proto
	modified:   format/property_group.proto
	modified:   format/types.proto
	modified:   format/vertex_info.proto

---------

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Co-authored-by: Weibin Zeng <qiaozi.zwb@alibaba-inc.com>
acezen added a commit that referenced this pull request Jun 13, 2024
* feat(spark): Refactoring datasources (#514)

### Reason for this PR
By moving datasources under `org.apache.spark.sql` we are able to access private Spark API. Last time when I was trying to fully migrate datasources to V2 it was a blocker. Detailed motivation is in #493 

### What changes are included in this PR?
Mostly refactoring.

### Are these changes tested?
Unit tests are passed

I manually checked the generated JARs:
![image](https://github.com/apache/incubator-graphar/assets/29755009/1b094516-88b1-490a-a2ea-8dcd092a3b1d)

### Are there any user-facing changes?
Mostly not because `GarDataSource` was left under the same package.


Close #493

* feat(dev): Add release and verify scripts (#507)

Reason for this PR
Add scripts for developer or release manager to easily release version or verify a version.

What changes are included in this PR?
Add release and verify scripts
related document is updated to website, see Update the release and verify document, and add development document incubator-graphar-website#18
Are these changes tested?
yes

Are there any user-facing changes?
no
---------

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* chore: Bump to version v0.12.0 (Round 1) (#517)


Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* chore: Add CHANGELOG.md (#513)


Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* Introduce buf

- v2
- buf.gen
- buf

 On branch format-definition-dev
 Your branch is up to date with 'origin/format-definition-dev'.

 Changes to be committed:
	new file:   buf.gen.yaml
	new file:   buf.yaml
	modified:   format/adjacent_list.proto
	modified:   format/edge_info.proto
	modified:   format/graph_info.proto
	modified:   format/property_group.proto
	modified:   format/types.proto
	modified:   format/vertex_info.proto

---------

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Co-authored-by: Weibin Zeng <qiaozi.zwb@alibaba-inc.com>
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants