Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configuration to generate protos for Go. #573

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

yecol
Copy link
Contributor

@yecol yecol commented Aug 2, 2024

Reason for this PR

To address #543

What changes are included in this PR?

  • add configuration;
  • fix a typo: well -> will

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

buf.gen.yaml Outdated Show resolved Hide resolved
@yecol
Copy link
Contributor Author

yecol commented Aug 3, 2024

Screenshot 2024-08-03 at 10 36 42

It seems the oldest version is v1.28.1
Do you think it is an acceptable compatible version? /cc @SemyonSinchenko

@SemyonSinchenko
Copy link
Member

@yecol It looks like protobuf-go uses a different versioning. We can use 1.34.2, I checked and they are saying it is based on the v27-version of protoc. Sorry for the confusion.

@yecol
Copy link
Contributor Author

yecol commented Aug 3, 2024

Thanks @SemyonSinchenko, I revised it to v1.34.2.
I also drop a line of comments about the version compatibility. :)

Copy link
Member

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that contribution! LGTM

Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit be2d8e2 into apache:main Aug 5, 2024
2 checks passed
@yecol yecol deleted the goproto branch August 5, 2024 09:31
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants