Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spark): remove Utils.redact #600

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Aug 20, 2024

Reason for this PR

Since the redact has been copy to datasource, the code in Utils can be removed

What changes are included in this PR?

remove the redact code from Utils

Are these changes tested?

yes

Are there any user-facing changes?

no

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen acezen requested a review from SemyonSinchenko August 20, 2024 08:48
@acezen acezen changed the title chore(spark): remove unused code chore(spark): remove Utils.redact Aug 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.63%. Comparing base (60fcede) to head (95f5914).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #600      +/-   ##
============================================
+ Coverage     62.86%   66.63%   +3.76%     
- Complexity        0      226     +226     
============================================
  Files            60       21      -39     
  Lines          8340     2011    -6329     
  Branches        878      179     -699     
============================================
- Hits           5243     1340    -3903     
+ Misses         3097      515    -2582     
- Partials          0      156     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit b5ebedb into apache:main Aug 20, 2024
6 checks passed
acezen added a commit to Elssky/incubator-graphar that referenced this pull request Aug 27, 2024
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Sep 23, 2024
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants