Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devinfra): Add test coverage to CI to measure the covering code of unitest (PySpark) #601

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Elssky
Copy link
Contributor

@Elssky Elssky commented Aug 21, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@083f0d5). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage        ?   95.11%           
=======================================
  Files           ?        8           
  Lines           ?      737           
  Branches        ?        0           
=======================================
  Hits            ?      701           
  Misses          ?       36           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for that contribution!

Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit 359b829 into apache:main Aug 21, 2024
2 checks passed
@Elssky
Copy link
Contributor Author

Elssky commented Aug 21, 2024

Now there is a problem: we have three folders: pyspark, spark, cpp need to perform code coverage detection, and add to the three corresponding coverage yml for CI detection and upload to the codecov website, but in most cases every time we Only modify one folder, so there is only one yml for CI. The problem is that the codecov website will clear the yml files submitted by the previous commit, so only three ymls are executed in one commit to ensure that all three code coverage files are uploaded to the codecov website.

@Elssky
Copy link
Contributor Author

Elssky commented Aug 21, 2024

Now there is a problem: we have three folders: pyspark, spark, cpp need to perform code coverage detection, and add to the three corresponding coverage yml for CI detection and upload to the codecov website, but in most cases every time we Only modify one folder, so there is only one yml for CI. The problem is that the codecov website will clear the yml files submitted by the previous commit, so only three ymls are executed in one commit to ensure that all three code coverage files are uploaded to the codecov website.

I'll try to fix this

acezen pushed a commit to Elssky/incubator-graphar that referenced this pull request Aug 27, 2024
Elssky added a commit to Elssky/incubator-graphar that referenced this pull request Sep 23, 2024
Elssky added a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
@Elssky Elssky deleted the pyspark branch October 30, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants