-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devinfra): Add test coverage to CI to measure the covering code of unitest (PySpark) #601
Conversation
…of unitest (PySpark)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #601 +/- ##
=======================================
Coverage ? 95.11%
=======================================
Files ? 8
Lines ? 737
Branches ? 0
=======================================
Hits ? 701
Misses ? 36
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for that contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now there is a problem: we have three folders: pyspark, spark, cpp need to perform code coverage detection, and add to the three corresponding coverage yml for CI detection and upload to the codecov website, but in most cases every time we Only modify one folder, so there is only one yml for CI. The problem is that the codecov website will clear the yml files submitted by the previous commit, so only three ymls are executed in one commit to ensure that all three code coverage files are uploaded to the codecov website. |
I'll try to fix this |
…of unitest (PySpark) (apache#601)
…of unitest (PySpark) (apache#601)
…of unitest (PySpark) (apache#601)
No description provided.