Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): add libprotobuf-dev in setup-ubuntu.sh #603

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Aug 23, 2024

Reason for this PR

C++ now rely on protobuf dependencies

find_package(Protobuf REQUIRED)

What changes are included in this PR?

add libprotobuf-dev in setup-ubuntu.sh

Are these changes tested?

yes

Are there any user-facing changes?

no

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
@acezen acezen requested a review from lixueclaire August 23, 2024 08:55
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit 5ce3a0b into apache:main Aug 23, 2024
1 check passed
acezen added a commit to Elssky/incubator-graphar that referenced this pull request Aug 27, 2024
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Sep 23, 2024
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants