Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(format): add segment for info in protobuf definiton #618

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Sep 4, 2024

Reason for this PR

What changes are included in this PR?

add segment to protobuf definiton

Are these changes tested?

yes

Are there any user-facing changes?

no

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Copy link
Contributor

@Thespica Thespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit cc57c56 into apache:main Sep 4, 2024
2 checks passed
@acezen acezen deleted the 617-add-version branch September 4, 2024 14:48
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Sep 23, 2024
* feat(format): add  segment for info in protobuf definiton

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* Reset that vertices and edges are the paths to vertex info and edge info

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* Update

---------

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Elssky pushed a commit to Elssky/incubator-graphar that referenced this pull request Oct 8, 2024
* feat(format): add  segment for info in protobuf definiton

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* Reset that vertices and edges are the paths to vertex info and edge info

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

* Update

---------

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(format): add version segment for graph/vertex/edge info in protobuf definition
2 participants