Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spark): fix typo in writer #648

Merged
merged 3 commits into from
Oct 26, 2024
Merged

chore(spark): fix typo in writer #648

merged 3 commits into from
Oct 26, 2024

Conversation

jasinliu
Copy link
Contributor

Reason for this PR

As title.

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@jasinliu jasinliu requested a review from acezen October 24, 2024 11:06
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.28%. Comparing base (b1ebb8e) to head (9499450).

Files with missing lines Patch % Lines
...n/scala/org/apache/graphar/writer/EdgeWriter.scala 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main     #648       +/-   ##
=============================================
+ Coverage     62.50%   74.28%   +11.78%     
- Complexity        0      226      +226     
=============================================
  Files            60       29       -31     
  Lines          8480     2749     -5731     
  Branches        877      179      -698     
=============================================
- Hits           5300     2042     -3258     
+ Misses         3180      551     -2629     
- Partials          0      156      +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SemyonSinchenko SemyonSinchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@acezen acezen merged commit cfb6d5f into apache:main Oct 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants