feat(c++): add function and example for read and write label chunk #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elssky
commented
Oct 28, 2024
There was a problem hiding this comment.
After considering, here I changed the parameter name back to ': LABEL', mainly because it is consistent with the column name in the original csv file, so as to avoid confusing users when operating arrow tables.
|
@lixueclaire please review :) |
Elssky
force-pushed
the
label-function
branch
from
8b576b1 to
7c3cd55
Compare
Elssky
force-pushed
the
label-function
branch
from
7c3cd55 to
a877b23
Compare
Elssky
added a commit
to Elssky/incubator-graphar
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
add function for support label related fuction.
What changes are included in this PR?
chunk_reader, chunk_writer and test cases.
Are these changes tested?
yes
Are there any user-facing changes?