Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Commit

Permalink
Remove unnecessary Bookkeeper format init container from Helm chart (#…
Browse files Browse the repository at this point in the history
…3795)

Co-authored-by: Billy Romansky <wromansky@protonmail.com>
  • Loading branch information
nicknezis and wromansky authored Mar 19, 2022
1 parent a06dcd4 commit ef20cf5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 17 deletions.
2 changes: 1 addition & 1 deletion deploy/kubernetes/helm/Chart.yaml.template
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
apiVersion: v2
name: heron
version: VERSION
kubeVersion: >= 1.16
kubeVersion: ">=1.16"
appVersion: VERSION
description: Heron is a fast distributed streaming engine for processing large data volumes with velocity
type: application
Expand Down
17 changes: 1 addition & 16 deletions deploy/kubernetes/helm/templates/bookie.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ spec:
values:
- {{ .Release.Name }}-bookkeeper
topologyKey: "kubernetes.io/hostname"
{{- end }}
terminationGracePeriodSeconds: 0
{{- end }}
initContainers:
# Wait until the zookeeper pods are up and running
- name: bookie-init-container
Expand All @@ -131,21 +131,6 @@ spec:
echo 'Zookeeper {{ .Release.Name }}-zookeeper:{{ .Values.zookeeper.clientPort }} not ready';
sleep 4;
done
{{- if eq .Values.platform "minikube" }}
# The first time, initialize BK to wipe data for minikube
- name: bookie-format
image: {{ .Values.bookkeeper.image }}
args: ["/opt/bookkeeper/bin/bookkeeper", "shell", "bookieformat", "-nonInteractive", "-force"]
command: [ "/bin/bash", "/opt/bookkeeper/scripts/entrypoint.sh" ]
envFrom:
- configMapRef:
name: {{ .Release.Name }}-bookie-config
volumeMounts:
- name: journal-disk
mountPath: /bookkeeper/data/journal
- name: ledgers-disk
mountPath: /bookkeeper/data/ledgers
{{- end }}
containers:
- name: bookie
image: {{ .Values.bookkeeper.image }}
Expand Down

0 comments on commit ef20cf5

Please sign in to comment.