This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Pex without interpreter cache disabled #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
objmagic
changed the title
| @@ -169,12 +170,15 @@ def pex_test_impl(ctx): | |||
| pex_test_files = pex_test_file_types.filter(pex_file_types.filter(transitive_sources)) | |||
| test_run_args = ' '.join([f.path for f in pex_test_files]) | |||
|
|
|||
| arguments = ["--disable-cache"] | |||
There was a problem hiding this comment.
could we instead set this in common_pex_arguments() so we don't have to set it in two places?
|
👍 merge it if @billonahill is fine with it. |
|
👍 for code changes, but CI is failing. |
restarted CI. |
|
merged since CI is OK |
|
@benley you might be interested in this.. |
|
indeed, thanks for the mention :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lovely PR disables interpreter cache because resolver.py L260-L263 is known to fail build due to some caching problem.
cf. pex-tool/pex#293
cc @kramasamy @billonahill