This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Improve PackingPlanTest #1214
Merged
Improve PackingPlanTest #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ | |||
| import com.twitter.heron.spi.common.Constants; | |||
|
|
|||
| public class PackingPlanTest { | |||
| public static PackingPlan generatePacking(Map<String, List<String>> basePacking) { | |||
| private static PackingPlan generatePacking(Map<String, List<String>> basePacking) { | |||
| Resource resource = | |||
There was a problem hiding this comment.
do we need this with the new change?
There was a problem hiding this comment.
Access isn't needed outside of this class and won't be when I add a serde test, since I was going to add it to this class as well.
There was a problem hiding this comment.
I was not clear - I meant the variable "resource"
There was a problem hiding this comment.
Yes, it's still used in the ContainerPlan and the PackingPlan objects below. I just changed to a resource for each instance that was unique, so I could assert on that.
added 2 commits
August 3, 2016 23:12
|
👍 |
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
* fix checkstyles * fix checkstyles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup PackingPlanTest and add assertions for getComponentRamDistribution.
I'm going to add tests for PackingPlan serde to this one and wanted to commit other unrelated cleanup items first.